refactor(platform): centralize vehicle lookup rules

This commit is contained in:
lingniu
2026-07-04 00:08:35 +08:00
parent 0503b03aa1
commit ff1fb4d2ac
4 changed files with 67 additions and 34 deletions

View File

@@ -0,0 +1,41 @@
import { describe, expect, test } from 'vitest';
import type { QualityIssueRow } from '../api/types';
import { qualityIssueVehicleLookup } from './vehicleLookup';
function issue(row: Partial<QualityIssueRow>): QualityIssueRow {
return {
vin: '',
plate: '',
phone: '',
sourceEndpoint: '',
protocol: 'JT808',
issueType: 'VIN_MISSING',
severity: 'warning',
lastSeen: '',
detail: '',
...row
};
}
describe('qualityIssueVehicleLookup', () => {
test('prefers a valid VIN', () => {
expect(qualityIssueVehicleLookup(issue({ vin: 'VIN001', plate: '粤A12345', phone: '13300000001' }))).toEqual({
key: 'VIN001',
label: '车辆服务'
});
});
test('uses plate when VIN is missing', () => {
expect(qualityIssueVehicleLookup(issue({ vin: 'unknown', plate: '粤A12345', phone: '13300000001' }))).toEqual({
key: '粤A12345',
label: '按车牌查车'
});
});
test('uses phone when VIN and plate are missing', () => {
expect(qualityIssueVehicleLookup(issue({ vin: 'unknown', phone: '13300000001' }))).toEqual({
key: '13300000001',
label: '按手机号查车'
});
});
});

View File

@@ -0,0 +1,22 @@
import type { QualityIssueRow } from '../api/types';
export type VehicleLookup = {
key: string;
label: string;
};
export function qualityIssueVehicleLookup(row: QualityIssueRow): VehicleLookup {
const vin = row.vin?.trim();
if (vin && vin !== 'unknown') {
return { key: vin, label: '车辆服务' };
}
const plate = row.plate?.trim();
if (plate) {
return { key: plate, label: '按车牌查车' };
}
const phone = row.phone?.trim();
if (phone) {
return { key: phone, label: '按手机号查车' };
}
return { key: '', label: '车辆服务' };
}

View File

@@ -4,6 +4,7 @@ import { api } from '../api/client';
import type { DashboardSummary, LinkHealth, ProtocolStat, QualityIssueRow, VehicleCoverageRow, VehicleRealtimeRow } from '../api/types';
import { PageHeader } from '../components/PageHeader';
import { StatusTag } from '../components/StatusTag';
import { qualityIssueVehicleLookup } from '../domain/vehicleLookup';
const statusColor: Record<string, 'green' | 'orange' | 'red' | 'grey'> = {
ok: 'green',
@@ -15,22 +16,6 @@ function formatLag(value?: number | null) {
return value == null ? '未接入' : value.toLocaleString();
}
function qualityVehicleLookup(row: QualityIssueRow) {
const vin = row.vin?.trim();
if (vin && vin !== 'unknown') {
return { key: vin, label: '车辆服务' };
}
const plate = row.plate?.trim();
if (plate) {
return { key: plate, label: '按车牌查车' };
}
const phone = row.phone?.trim();
if (phone) {
return { key: phone, label: '按手机号查车' };
}
return { key: '', label: '车辆服务' };
}
export function Dashboard({ onOpenVehicle, onOpenQuality }: { onOpenVehicle: (vin: string) => void; onOpenQuality: () => void }) {
const [summary, setSummary] = useState<DashboardSummary | null>(null);
const [coverage, setCoverage] = useState<VehicleCoverageRow[]>([]);
@@ -148,7 +133,7 @@ export function Dashboard({ onOpenVehicle, onOpenQuality }: { onOpenVehicle: (vi
title: '操作',
width: 130,
render: (_: unknown, row: QualityIssueRow) => {
const lookup = qualityVehicleLookup(row);
const lookup = qualityIssueVehicleLookup(row);
return <Button disabled={!lookup.key} onClick={() => onOpenVehicle(lookup.key)}>{lookup.label}</Button>;
}
}

View File

@@ -4,6 +4,7 @@ import { useEffect, useState } from 'react';
import { api } from '../api/client';
import type { OpsHealth, QualitySummary, QualityIssueRow } from '../api/types';
import { PageHeader } from '../components/PageHeader';
import { qualityIssueVehicleLookup } from '../domain/vehicleLookup';
const statusColor: Record<string, 'green' | 'orange' | 'red' | 'grey'> = {
ok: 'green',
@@ -49,22 +50,6 @@ async function copyText(value: string, label: string) {
}
}
function vehicleLookup(row: QualityIssueRow) {
const vin = row.vin?.trim();
if (vin && vin !== 'unknown') {
return { key: vin, label: '车辆服务' };
}
const plate = row.plate?.trim();
if (plate) {
return { key: plate, label: '按车牌查车' };
}
const phone = row.phone?.trim();
if (phone) {
return { key: phone, label: '按手机号查车' };
}
return { key: '', label: '车辆服务' };
}
export function Quality({
onOpenVehicle,
onHealthLoaded
@@ -194,7 +179,7 @@ export function Quality({
title: '操作',
width: 250,
render: (_: unknown, row: QualityIssueRow) => {
const lookup = vehicleLookup(row);
const lookup = qualityIssueVehicleLookup(row);
return (
<Space spacing={4}>
<Button size="small" icon={<IconCopy />} onClick={() => copyText(row.phone, '手机号')}></Button>