shishengliang/lingniu-vehicle-ingest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: simplify jt808 daily mileage strategy

Browse Source
This commit is contained in:
lingniu
2026-07-01 08:01:12 +08:00
parent 59e8315fe6
commit 80d3afa80a
3 changed files with 12 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
modules/services/vehicle-stat-service/src/main/java/com/lingniu/ingest/vehiclestat/DailyMileageStrategy.java
View File

@@ -8,9 +8,6 @@ public enum DailyMileageStrategy {
return JT808_TOTAL_MILEAGE_DIFF;
}
String normalized = value.trim();
if ("CURRENT_LAST_MINUS_PREVIOUS_LAST".equals(normalized)) {
return JT808_TOTAL_MILEAGE_DIFF;
}
return DailyMileageStrategy.valueOf(normalized);
}
}

11
modules/services/vehicle-stat-service/src/test/java/com/lingniu/ingest/vehiclestat/JdbcVehicleStatMetricRepositoryTest.java
View File

@@ -7,6 +7,7 @@ import org.springframework.jdbc.datasource.DriverManagerDataSource;
import java.time.LocalDate;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
class JdbcVehicleStatMetricRepositoryTest {
@@ -147,7 +148,7 @@ class JdbcVehicleStatMetricRepositoryTest {
}
@Test
void readsLegacyCalculationMethodAsTotalMileageDifference() {
void rejectsLegacyPreviousDayCalculationMethod() {
JdbcTemplate jdbcTemplate = new JdbcTemplate(new DriverManagerDataSource(
"jdbc:h2:mem:vehicle_stat_metric_legacy;MODE=MySQL;DATABASE_TO_LOWER=TRUE;DB_CLOSE_DELAY=-1",
"sa",
@@ -159,10 +160,8 @@ class JdbcVehicleStatMetricRepositoryTest {
VALUES ('VIN001', DATE '2026-06-30', 'daily_mileage_km', 8.5, 'km', 'CURRENT_LAST_MINUS_PREVIOUS_LAST')
""");
assertThat(repository.findDailyStat("VIN001", LocalDate.of(2026, 6, 30)))
.isPresent()
.get()
.extracting(VehicleDailyStatResult::dailyMileageStrategy)
.isEqualTo(DailyMileageStrategy.JT808_TOTAL_MILEAGE_DIFF);
assertThatThrownBy(() -> repository.findDailyStat("VIN001", LocalDate.of(2026, 6, 30)))
.isInstanceOf(IllegalArgumentException.class)
.hasMessageContaining("CURRENT_LAST_MINUS_PREVIOUS_LAST");
}
}