fix(go): skip empty frames in realtime snapshot

This commit is contained in:
lingniu
2026-07-02 16:11:58 +08:00
parent dac6718ee4
commit 5b2e1abcdd
2 changed files with 36 additions and 0 deletions

View File

@@ -35,6 +35,9 @@ func (w *SnapshotWriter) Update(ctx context.Context, env envelope.FrameEnvelope)
if vehicleKey == "" || strings.HasSuffix(vehicleKey, ":unknown") { if vehicleKey == "" || strings.HasSuffix(vehicleKey, ":unknown") {
return nil return nil
} }
if !hasRealtimePayload(env) {
return nil
}
fieldsJSON, err := marshalObject(env.Fields) fieldsJSON, err := marshalObject(env.Fields)
if err != nil { if err != nil {
return err return err
@@ -82,6 +85,16 @@ func nullableTime(ms int64) any {
return time.UnixMilli(ms) return time.UnixMilli(ms)
} }
func hasRealtimePayload(env envelope.FrameEnvelope) bool {
if len(env.Fields) > 0 {
return true
}
if _, ok := env.Parsed["data_units"]; ok {
return true
}
return false
}
const realtimeSnapshotTableSQL = `CREATE TABLE IF NOT EXISTS vehicle_realtime_snapshot ( const realtimeSnapshotTableSQL = `CREATE TABLE IF NOT EXISTS vehicle_realtime_snapshot (
id BIGINT PRIMARY KEY AUTO_INCREMENT, id BIGINT PRIMARY KEY AUTO_INCREMENT,
protocol VARCHAR(32) NOT NULL, protocol VARCHAR(32) NOT NULL,

View File

@@ -75,6 +75,29 @@ func TestSnapshotWriterSkipsUnknownVehicleKey(t *testing.T) {
} }
} }
func TestSnapshotWriterSkipsGB32960HeartbeatWithoutRealtimePayload(t *testing.T) {
exec := &recordingSnapshotExec{}
writer := NewSnapshotWriter(exec)
if err := writer.Update(context.Background(), envelope.FrameEnvelope{
Protocol: envelope.ProtocolGB32960,
MessageID: "0x07",
VIN: "ABCDE600000000009",
Parsed: map[string]any{
"header": map[string]any{
"vin": "ABCDE600000000009",
"command": "0x07",
"actual_body_length": 0,
},
},
}); err != nil {
t.Fatalf("Update() error = %v", err)
}
if len(exec.calls) != 0 {
t.Fatalf("exec calls = %d, want 0", len(exec.calls))
}
}
type recordingSnapshotExec struct { type recordingSnapshotExec struct {
calls []snapshotExecCall calls []snapshotExecCall
} }