review：【antd/ele】【mall】商城相关的代码

apps/web-antd/src/views/bpm/model/modules/category-draggable-model.vue

@@ -464,8 +464,6 @@ function handleRenameSuccess() {
     >
       <div class="flex h-12 items-center">
         <!-- 头部：分类名 -->
-        <!-- 2）拖动后，直接请求排序，不用有个【保存】；排序模型分类，和排序分类里的模型，交互有点不同哈。
-            @芋艿 好像 yudao-ui-admin-vue3 交互也是这样的，需要改吗? -->
         <div class="flex items-center">
           <Tooltip v-if="isCategorySorting" title="拖动排序">
             <!-- drag-handle 标识可以拖动，不能删掉 -->

apps/web-antd/src/views/bpm/processInstance/create/modules/form.vue

@@ -168,10 +168,6 @@ async function initProcessInfo(row: any, formVariables?: any) {
     await router.push({
       path: row.formCustomCreatePath,
     });
-    // 返回选择流程
-    // 这里为啥要有个 cancel 事件哈？目前看 vue3 + element-plus 貌似不需要呀；
-    // @芋艿 不加貌似会有点问题。
-    emit('cancel');
   }
 }
 

apps/web-ele/src/views/mall/promotion/discountActivity/modules/form.vue

@@ -229,36 +229,32 @@ const [Modal, modalApi] = useVbenModal({
     if (!valid) {
       return;
     }
-
     // 校验是否选择了商品
     if (spuList.value.length === 0) {
       ElMessage.warning('请选择活动商品');
       return;
     }
-
     modalApi.lock();
+    // 提交表单
     try {
       // 获取折扣商品配置
       const products = cloneDeep(
         spuAndSkuListRef.value?.getSkuConfigs('productConfig') || [],
       ) as MallDiscountActivityApi.DiscountProduct[];
-
       // 转换金额为分
       products.forEach((item) => {
         item.discountPercent = convertToInteger(item.discountPercent);
         item.discountPrice = convertToInteger(item.discountPrice);
       });
-
       const data = cloneDeep(
         await formApi.getValues(),
       ) as MallDiscountActivityApi.DiscountActivity;
       data.products = products;
-
       // 提交请求
       await (formData.value?.id
         ? updateDiscountActivity(data)
         : createDiscountActivity(data));
-
+      // 关闭并提示
       await modalApi.close();
       emit('success');
       ElMessage.success($t('ui.actionMessage.operationSuccess'));
@@ -271,18 +267,15 @@ const [Modal, modalApi] = useVbenModal({
       await resetForm();
       return;
     }
-
     // 加载数据
     const data = modalApi.getData<MallDiscountActivityApi.DiscountActivity>();
     if (!data || !data.id) {
       return;
     }
-
     modalApi.lock();
     try {
       const activityData = await getDiscountActivity(data.id);
       formData.value = activityData;
-
       // 加载商品详情
       if (activityData.products && activityData.products.length > 0) {
         // 按 spuId 分组
@@ -297,15 +290,13 @@ const [Modal, modalApi] = useVbenModal({
           }
           spuProductsMap.get(spuId)!.push(product);
         }
-
         // 加载每个 SPU 的详情
         for (const [spuId, products] of spuProductsMap) {
           const skuIdArr = products.map((p) => p.skuId);
           await getSpuDetails(spuId, skuIdArr, products, 'load');
         }
       }
-
+      // 设置到 values
-      // 设置表单值
       await formApi.setValues(activityData);
     } finally {
       modalApi.unlock();

apps/web-ele/src/views/mall/promotion/rewardActivity/modules/form.vue

@@ -117,7 +117,6 @@ const [Modal, modalApi] = useVbenModal({
     modalApi.lock();
     try {
       const result = await getReward(data.id);
-      // valueFormat: 'x' 配置下，直接使用时间戳字符串
       result.startAndEndTime = [
         result.startTime ? String(result.startTime) : undefined,
         result.endTime ? String(result.endTime) : undefined,